pprovenzano commented on code in PR #14578:
URL: https://github.com/apache/kafka/pull/14578#discussion_r1369677542
##########
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##########
@@ -184,6 +185,8 @@ object BrokerMetadataCheckpoint extends Logging {
try {
brokerCheckpoint.read() match {
case Some(properties) =>
+ // XXX Should we check for duplicates here
Review Comment:
I've added it there. Let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
