CalvinConfluent commented on code in PR #14603: URL: https://github.com/apache/kafka/pull/14603#discussion_r1371084764
########## storage/src/main/java/org/apache/kafka/storage/internals/log/CleanShutdownFileHandler.java: ########## @@ -85,17 +83,16 @@ void write(long brokerEpoch, int version) throws Exception { } } - public long read() { - long brokerEpoch = -1L; + @SuppressWarnings("unchecked") + public OptionalLong read() { try { String text = Utils.readFileAsString(cleanShutdownFile.toPath().toString()); - Map<String, String> content = new ObjectMapper().readValue(text, HashMap.class); - - brokerEpoch = Long.parseLong(content.getOrDefault(Fields.BROKER_EPOCH.toString(), "-1L")); + Content content = new ObjectMapper().readValue(text, Content.class); Review Comment: You are right, downgrade is not flexible here. New fields will break the parser. Will revert the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org