gnarula commented on code in PR #14625:
URL: https://github.com/apache/kafka/pull/14625#discussion_r1372058951
##########
clients/src/test/java/org/apache/kafka/common/record/DefaultRecordBatchTest.java:
##########
@@ -63,15 +61,9 @@
import static org.mockito.Mockito.when;
public class DefaultRecordBatchTest {
- private static final Random RANDOM;
-
- static {
- try {
- RANDOM = SecureRandom.getInstanceStrong();
- } catch (NoSuchAlgorithmException e) {
- throw new RuntimeException(e);
- }
- }
+ // We avoid SecureRandom.getInstanceStrong() here because it reads from
/dev/random and blocks on Linux. Since these
+ // tests don't require cryptographically strong random data, we avoid a
CSPRNG (SecureRandom) altogether.
+ private static final Random RANDOM = new Random();
Review Comment:
Addressed in
[afc7129](https://github.com/apache/kafka/pull/14625/commits/afc71297c805eb149a3dee450cd4e204c4fb57d9)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
