rreddy-22 commented on code in PR #14524:
URL: https://github.com/apache/kafka/pull/14524#discussion_r1372146226


##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -277,6 +279,22 @@ def __init__(self, context, num_nodes, zk, 
security_protocol=SecurityConfig.PLAI
         self.isolated_controller_quorum = None # will define below if necessary
         self.configured_for_zk_migration = False
 
+        default_use_new_coordinator = False
+        
+        # If 'use_new_coordinator' is not explicitly set, determine it based 
on context.
+        if use_new_coordinator is None:
+            arg_name = 'use_new_coordinator'
+
+            # Default to the global setting if no arguments are injected.
+            if not context.injected_args:

Review Comment:
   > What would happen if context.injected_args is defined but not for 
use_new_coordinator
   
   If get doesn't find the arg name then it uses the default value I provided 
as the second argument



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to