florin-akermann commented on code in PR #14174: URL: https://github.com/apache/kafka/pull/14174#discussion_r1372233874
########## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ########## @@ -351,8 +353,23 @@ private void optimizeTopology(final Properties props) { LOG.debug("Optimizing the Kafka Streams graph for self-joins"); rewriteSingleStoreSelfJoin(root, new IdentityHashMap<>()); } + LOG.debug("Optimizing the Kafka Streams graph for null-key records"); + rewriteRepartitionNodes(); } + private void rewriteRepartitionNodes() { Review Comment: Ok, so basically we remove this optimization completley for now? Developers could still just filter out null keys with a 'filter' operator to achieve the old behavior. And then we make a separate ticket where developers can opt in to this optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org