apoorvmittal10 commented on PR #14621: URL: https://github.com/apache/kafka/pull/14621#issuecomment-1780865857
> Hi @apoorvmittal10 Thanks for taking my suggestions. I left a few more, mostly about the aesthetic aspect as scala is a pretty idiomatic language... > > Terribly sorry that I don't have a lot of knowledge around the server side, so I can't provide advice on detail implementation - but I think your PR is clean and I can almost fully understand the intention. Thanks for the review. It's helpful and using scala for the first time, sorry about issues. It ll get better from next PRs. I haven't yet addressed your suggestions in new classes as I have asked @hachikuji if it makes more sense to write then in Java, as I see new classes for `core` are now written in Java itself. cc: @junrao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
