CalvinConfluent commented on code in PR #14594: URL: https://github.com/apache/kafka/pull/14594#discussion_r1373418439
########## core/src/main/scala/kafka/cluster/Partition.scala: ########## @@ -359,10 +361,14 @@ class Partition(val topicPartition: TopicPartition, // a false positive under min isr check, it has to check the leaderReplicaIdOpt again. Though it can still be affected // by ABA problems when leader->follower->leader, but it should be good enough for a metric. def isUnderMinIsr: Boolean = { - leaderLogIfLocal.exists { partitionState.isr.size < _.config.minInSyncReplicas } && isLeader + leaderLogIfLocal.exists{partitionState.isr.size < effectiveMinIsr(_) } && isLeader Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org