lucasbru commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374443906
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -105,6 +105,23 @@ public class ConsumerConfig extends AbstractConfig {
public static final String HEARTBEAT_INTERVAL_MS_CONFIG =
CommonClientConfigs.HEARTBEAT_INTERVAL_MS_CONFIG;
private static final String HEARTBEAT_INTERVAL_MS_DOC =
CommonClientConfigs.HEARTBEAT_INTERVAL_MS_DOC;
+ /**
+ * <code>group.protocol</code>
+ */
+ public static final String GROUP_PROTOCOL_CONFIG = "group.protocol";
+ public static final String DEFAULT_GROUP_PROTOCOL =
GroupProtocol.GENERIC.name().toLowerCase();
+ public static final String GROUP_PROTOCOL_DOC = "The rebalance protocol
consumer should use. We currently " +
Review Comment:
Maybe we should stick with "group protocol" and not use the synonymous
"rebalance protocol" here, although I know we use this interchangeably.
Also, maybe that's just the non-native speaker in me, but for me the
sentence would be easier to parse with an article for consumer.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -105,6 +105,23 @@ public class ConsumerConfig extends AbstractConfig {
public static final String HEARTBEAT_INTERVAL_MS_CONFIG =
CommonClientConfigs.HEARTBEAT_INTERVAL_MS_CONFIG;
private static final String HEARTBEAT_INTERVAL_MS_DOC =
CommonClientConfigs.HEARTBEAT_INTERVAL_MS_DOC;
+ /**
+ * <code>group.protocol</code>
+ */
+ public static final String GROUP_PROTOCOL_CONFIG = "group.protocol";
+ public static final String DEFAULT_GROUP_PROTOCOL =
GroupProtocol.GENERIC.name().toLowerCase();
+ public static final String GROUP_PROTOCOL_DOC = "The rebalance protocol
consumer should use. We currently " +
+ "support \"generic\" or \"consumer\". If \"consumer\" is specified,
then the consumer group protocol will be " +
+ "used. Otherwise, the generic group protocol will be used.";
+
+ /**
+ * <code>group.remote.assignor</code>
+ */
+ public static final String REMOTE_ASSIGNOR_CONFIG =
"group.remote.assignor";
+ public static final String DEFAULT_REMOTE_ASSIGNOR = null;
+ public static final String REMOTE_ASSIGNOR_DOC = "The server-side assignor
to use. If no assignor is specified, " +
Review Comment:
Should we specify that the settings only applies when group.protocol =
consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
