dengziming commented on code in PR #14517: URL: https://github.com/apache/kafka/pull/14517#discussion_r1375160304
########## server-common/src/main/java/org/apache/kafka/common/DirectoryId.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common; + +import java.util.Collections; +import java.util.HashSet; +import java.util.Set; + +public class DirectoryId { + + /** + * A UUID that is used to identify new or unknown dir assignments. + */ + public static final Uuid UNASSIGNED = new Uuid(0L, 0L); + + /** + * A UUID that is used to represent unspecified offline dirs. + */ + public static final Uuid LOST = new Uuid(0L, 1L); + + /** + * A UUID that is used to represent and unspecified log directory, + * that is expected to have been previously selected to host an + * associated replica. This contrasts with {@code UNASSIGNED_DIR}, + * which is associated with (typically new) replicas that may not + * yet have been placed in any log directory. + */ + public static final Uuid MIGRATING = new Uuid(0L, 2L); + + /** + * The set of reserved UUIDs that will never be returned by the random method. + */ + public static final Set<Uuid> RESERVED; + + static { + HashSet<Uuid> reserved = new HashSet<>(Uuid.RESERVED); + // The first 100 UUIDs are reserved for future use. + for (long i = 0L; i < 100L; i++) { + reserved.add(new Uuid(0L, i)); + } + RESERVED = Collections.unmodifiableSet(reserved); + } + + /** + * Static factory to generate a directory ID. + * + * This will not generate a reserved UUID (first 100), or one whose string representation starts with a dash ("-") + */ + public static Uuid random() { + Uuid uuid = Uuid.randomUuid(); + while (RESERVED.contains(uuid) || uuid.toString().startsWith("-")) { Review Comment: We don't need `uuid.toString().startsWith("-")` here, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
