mjsax commented on code in PR #14596:
URL: https://github.com/apache/kafka/pull/14596#discussion_r1379482103


##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java:
##########
@@ -157,6 +213,30 @@ protected <R> QueryResult<R> runKeyQuery(final Query<R> 
query,
             throw new UnsupportedOperationException("Versioned stores do not 
support KeyQuery queries at this time.");
         }
 
+        @SuppressWarnings("unchecked")
+        protected <R> QueryResult<R> runVersionedKeyQuery(final Query<R> query,

Review Comment:
   Why do we add this as `protected` ? Should be `private` IMHO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to