[
https://issues.apache.org/jira/browse/KAFKA-15710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782236#comment-17782236
]
Ron Dagostino commented on KAFKA-15710:
---------------------------------------
The KRaft equivalent of `testCleanShutdownWithZkUnavailable` was indeed added
via https://github.com/apache/kafka/pull/11606 (it is called
`testCleanShutdownWithKRaftControllerUnavailable`).
However, it appears there is no KRaft test equivalent of
`testControllerShutdownDuringSend`. I am not sure if need one, though. That
test starts 2 ZK-based brokers, one of which is the controller. It has that
controller accept the first request it receives (LeaderAndIsrRequest in the
test) but only read a single byte and then block. Then it has the
non-controller broker shutdown using the same `ControllerChannelManager`
instance. I think the idea is to confirm that shutdown still works when
another request is still being sent.
Given that KRaft brokers don't use `ControllerChannelManager`, I suspect this
test does not need a direct KRaft-equivalent.
> KRaft support in ServerShutdownTest
> -----------------------------------
>
> Key: KAFKA-15710
> URL: https://issues.apache.org/jira/browse/KAFKA-15710
> Project: Kafka
> Issue Type: Task
> Components: core
> Reporter: Sameer Tejani
> Priority: Minor
> Labels: kraft, kraft-test, newbie
>
> The following tests in ServerShutdownTest in
> core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala need to be
> updated to support KRaft
> 192 : def testCleanShutdownWithZkUnavailable(quorum: String): Unit = {
> 258 : def testControllerShutdownDuringSend(quorum: String): Unit = {
> Scanned 324 lines. Found 5 KRaft tests out of 7 tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
