kirktrue commented on code in PR #14670: URL: https://github.com/apache/kafka/pull/14670#discussion_r1380747077
########## clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java: ########## @@ -67,17 +67,11 @@ public void testOverrideClientId() { @Test public void testOverrideEnableAutoCommit() { ConsumerConfig config = new ConsumerConfig(properties); - boolean overrideEnableAutoCommit = config.maybeOverrideEnableAutoCommit(); - assertFalse(overrideEnableAutoCommit); +// boolean overrideEnableAutoCommit = InternalConsumerConfig.maybeOverrideEnableAutoCommit(config); Review Comment: Agreed. I revised this test method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org