[ 
https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782881#comment-17782881
 ] 

jinlong wang commented on KAFKA-15341:
--------------------------------------

After check the logic. It seems that the 
`FeatureControlManager.reasonNotSupported` can check all broker support 
features and throw one exception to indicate which broker not enabled feature.

My plan to implement this check by following steps:
 # Report in TieredStorage feature when broker register to controller
 # When handle AlterConfig request enable remotestorage config on topic, 
controller will use FeatureControlManager to check if all broker enabled 
TieredStorage and return the result of AlterConfig if success.

The point need guide that how do we set the min and max version for the the 
VersionedFeature for TieredStrage.

> Enabling TS for a topic during rolling restart causes problems
> --------------------------------------------------------------
>
>                 Key: KAFKA-15341
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15341
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Divij Vaidya
>            Priority: Major
>              Labels: KIP-405
>             Fix For: 3.7.0
>
>
> When we are in a rolling restart to enable TS at system level, some brokers 
> have TS enabled on them and some don't. We send an alter config call to 
> enable TS for a topic, it hits a broker which has TS enabled, this broker 
> forwards it to the controller and controller will send the config update to 
> all brokers. When another broker which doesn't have TS enabled (because it 
> hasn't undergone the restart yet) gets this config change, it "should" fail 
> to apply it. But failing now is too late since alterConfig has already 
> succeeded since controller->broker config propagation is done async.
> With this JIRA, we want to have controller check if TS is enabled on all 
> brokers before applying alter config to turn on TS for a topic.
> Context: https://github.com/apache/kafka/pull/14176#discussion_r1291265129



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to