junrao commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-1795952612
One discussion of the PR is around choosing the default value for `compression.level` (https://github.com/apache/kafka/pull/10826#discussion_r917108950). This is tricky since it's specific to the compression type. I am wondering if it's better to adjust the KIP to support `compression.{gzip|lz4|zstd}.level` instead. This will make it more aligned with the future KIP https://cwiki.apache.org/confluence/display/KAFKA/KIP-780%3A+Support+fine-grained+compression+options#KIP780:Supportfinegrainedcompressionoptions-Zstd.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
