jolshan commented on code in PR #14387: URL: https://github.com/apache/kafka/pull/14387#discussion_r1384119244
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -120,6 +121,9 @@ import static org.apache.kafka.coordinator.group.generic.GenericGroupState.EMPTY; import static org.apache.kafka.coordinator.group.generic.GenericGroupState.PREPARING_REBALANCE; import static org.apache.kafka.coordinator.group.generic.GenericGroupState.STABLE; +import static org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetrics.COMPLETED_REBALANCES_SENSOR_NAME; Review Comment: Yeah, I wasn't sure if it would be better to just not say "generic" in front, or if that makes it unclear that its the generic group 😅 ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -120,6 +121,9 @@ import static org.apache.kafka.coordinator.group.generic.GenericGroupState.EMPTY; import static org.apache.kafka.coordinator.group.generic.GenericGroupState.PREPARING_REBALANCE; import static org.apache.kafka.coordinator.group.generic.GenericGroupState.STABLE; +import static org.apache.kafka.coordinator.group.metrics.GroupCoordinatorMetrics.COMPLETED_REBALANCES_SENSOR_NAME; Review Comment: Yeah, I wasn't sure if it would be better to just not say "generic" in front, or if that makes it unclear that its the generic group 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
