jolshan commented on code in PR #14721:
URL: https://github.com/apache/kafka/pull/14721#discussion_r1388381937
##########
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java:
##########
@@ -99,7 +100,7 @@ public void configure(Map<String, ?> configs) throws
KafkaException {
try {
SslEngineValidator.validate(builder, builder);
} catch (Exception e) {
- throw new ConfigException("A client SSLEngine created with the
provided settings " +
+ throw new InvalidConfigurationException("A client SSLEngine
created with the provided settings " +
Review Comment:
Usages here are a bit tricky to track. So many overrided "configure" methods
that go in circles 😅
@bob-barrett do you have a simplified flow for this to confirm it won't
cause compatibility issues?
##########
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java:
##########
@@ -99,7 +100,7 @@ public void configure(Map<String, ?> configs) throws
KafkaException {
try {
SslEngineValidator.validate(builder, builder);
} catch (Exception e) {
- throw new ConfigException("A client SSLEngine created with the
provided settings " +
+ throw new InvalidConfigurationException("A client SSLEngine
created with the provided settings " +
Review Comment:
Usages here are a bit tricky to track. So many overrided "configure" methods
that go in circles 😅
@bob-barrett do you have a simplified flow for this to confirm it won't
cause compatibility issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
