hgeraldino commented on PR #14663: URL: https://github.com/apache/kafka/pull/14663#issuecomment-1806906866
One thing I'd like to know is if this approach of multiple bite-sized PRs seems reasonable or not. Future PRs might include refactor of more than one method, but I'll try my best to keep them in the smaller side (with the downside that there will be many more than should) > It's such a big file that doing it incrementally may make the reviews easier. That said a lot of changes should be mechanical and similar across all tests so we probably don't want to do >10PRs for example. Makes sense. There are 31 tests in this class, I'll try to do them in batches of 3/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
