OmniaGM commented on PR #14369: URL: https://github.com/apache/kafka/pull/14369#issuecomment-1810263837
I agree with @cmccabe regarding passing a reference for `AssignmentHandler` to `ReplicaManager`. Maybe one other note, many integration tests are failing now with the following error ``` Error applying topics delta in MetadataDelta up to 78: Assignment into unidentified directory: /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-14369/tools/data/kafka-2762391009500302231 at app//kafka.server.ReplicaManager.maybeNotifyPartitionAssignedToDirectory(ReplicaManager.scala:2362) ``` for example https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14369/11/testReport/junit/kafka.api/PlaintextAdminIntegrationTest/Build___JDK_8_and_Scala_2_12___testElectUncleanLeadersNoop_String__quorum_kraft/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org