lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1394581206
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -77,32 +138,111 @@ public class MembershipManagerImpl implements
MembershipManager {
/**
* Assignment that the member received from the server and successfully
processed.
*/
- private ConsumerGroupHeartbeatResponseData.Assignment currentAssignment;
+ private Set<TopicPartition> currentAssignment;
/**
- * Assignment that the member received from the server but hasn't
completely processed
- * yet.
+ * Subscription state object holding the current assignment the member has
for the topics it
+ * subscribed to.
*/
- private Optional<ConsumerGroupHeartbeatResponseData.Assignment>
targetAssignment;
+ private final SubscriptionState subscriptions;
+
+ /**
+ * Metadata that allows us to create the partitions needed for {@link
ConsumerRebalanceListener}.
+ */
+ private final ConsumerMetadata metadata;
+
+ /**
+ * TopicPartition comparator based on topic name and partition id.
+ */
+ private final static TopicPartitionComparator COMPARATOR = new
TopicPartitionComparator();
Review Comment:
Done, re-arranged a couple of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
