jolshan opened a new pull request, #14774: URL: https://github.com/apache/kafka/pull/14774
Rewrote the verification flow to have 3 stages 1. collect the partitions that need verification 2. with the callback result separate results into errors and verified partitions 3. Perform the action we wanted to do now with verified partitions Steps 2 and 3 will be done in the wrapped callback that executes on an arbitrary request thread. Note that 3 is now more generalized (not just append) and is any callback specified by the method that wishes to do verification. I also tried to separate and compartmentalize the methods to avoid the interface from getting too muddy with verification when it does not need to be. appendRecords now only takes two arguments that come from verification and the method can be called directly by callers that do not need verification. WIP -- I still need to clean up the method documentation and typing here. Also add tests ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
