hudeqi commented on code in PR #14729:
URL: https://github.com/apache/kafka/pull/14729#discussion_r1395121316
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -1373,6 +1384,9 @@ private[kafka] class Processor(
try {
beginShutdown()
thread.join()
+ if (!started) {
Review Comment:
When `socketServer` executes `close`, if `started` of `socketServer` is
true, then the logic of `closeAll` can be executed in finally. If `started` of
`socketServer` is false, then it is also executed the logic of `closeAll` at
line 683 , so for the `close` of the processor, is there still a redundant call
to `closeAll`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
