[ 
https://issues.apache.org/jira/browse/KAFKA-7058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16512606#comment-16512606
 ] 

Randall Hauch edited comment on KAFKA-7058 at 6/15/18 10:35 PM:
----------------------------------------------------------------

[~gunnar.morling] thanks for the PR. It looks good, but we're a few days past 
code freeze and even though this is a small change I'm not sure we can call 
this a real blocker. I'm going to approve it, but we'll probably have to wait 
until after the 2.0 release to merge. The good news is that this should 
backport pretty cleanly back to the 0.9 or 0.10 branches, and so it would be in 
the next patch release on the various branches whenever they occur.


was (Author: rhauch):
[~gunnar.morling] thanks for the PR. It looks good, but we're a few days past 
code freeze and even though this is a small change I'm not sure we can call 
this a real blocker. I'm going to approve it, but we'll probably have to wait 
until after the 2.0 release to merge. The good news is that this should 
backport pretty cleanly back to the 0.10 branch, and so it would be in the next 
patch release on the various branches whenever they occur.

> ConnectSchema#equals() broken for array-typed default values
> ------------------------------------------------------------
>
>                 Key: KAFKA-7058
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7058
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: Gunnar Morling
>            Priority: Major
>
> {{ConnectSchema#equals()}} calls {{Objects#equals()}} for the schemas' 
> default values, but this doesn't work correctly if the default values in fact 
> are arrays. In this case, always {{false}} will be returned, also if the 
> default value arrays actually are the same.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to