rreddy-22 commented on code in PR #14582:
URL: https://github.com/apache/kafka/pull/14582#discussion_r1396190264
##########
tests/kafkatest/tests/core/transactions_test.py:
##########
@@ -246,8 +246,9 @@ def setup_topics(self):
@matrix(failure_mode=["hard_bounce", "clean_bounce"],
bounce_target=["brokers", "clients"],
check_order=[True, False],
- use_group_metadata=[True, False])
- def test_transactions(self, failure_mode, bounce_target, check_order,
use_group_metadata, metadata_quorum=quorum.all):
+ use_group_metadata=[True, False],
+ use_new_coordinator=[True, False])
Review Comment:
hmm weirdly it passes 😕 I see quorum.all specified in the test args but I
think it should be in the matrix so all the combinations run. I'll change it
and run it to confirm. Thanks for the catch!
##########
tests/kafkatest/tests/core/transactions_test.py:
##########
@@ -246,8 +246,9 @@ def setup_topics(self):
@matrix(failure_mode=["hard_bounce", "clean_bounce"],
bounce_target=["brokers", "clients"],
check_order=[True, False],
- use_group_metadata=[True, False])
- def test_transactions(self, failure_mode, bounce_target, check_order,
use_group_metadata, metadata_quorum=quorum.all):
+ use_group_metadata=[True, False],
+ use_new_coordinator=[True, False])
Review Comment:
hmm weirdly it passes 😕 I see quorum.all specified in the test args but I
think it should be in the matrix so all the combinations run. I'll change it
and run it to confirm. Thanks for the catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
