dongnuo123 commented on code in PR #14781:
URL: https://github.com/apache/kafka/pull/14781#discussion_r1396303939


##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -77,8 +83,9 @@ class ConsumerBounceTest extends AbstractConsumerTest with 
Logging {
     }
   }
 
-  @Test
-  def testConsumptionWithBrokerFailures(): Unit = consumeWithBrokerFailures(10)
+  @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+  @ValueSource(strings = Array("zk", "kraft", "kraft+kip848"))
+  def testConsumptionWithBrokerFailures(quorum: String): Unit = 
consumeWithBrokerFailures(10)

Review Comment:
   This is the only one flaky. 
   
   The test fails because somehow the consumer coordinator loses its generation 
(generation == null).
   
   I guess it's related to timeout issue, because zk broker also fails in the 
same way when setting break points. Maybe something also needs time to 
propagate and reaches timeout before consumer coordinator updates the 
generation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to