ijuma commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1398324375
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -1048,20 +1054,15 @@ class KafkaServer(
*
* @return The brokerId.
*/
- private def getOrGenerateBrokerId(brokerMetadata: RawMetaProperties): Int = {
- val brokerId = config.brokerId
-
- if (brokerId >= 0 && brokerMetadata.brokerId.exists(_ != brokerId))
- throw new InconsistentBrokerIdException(
Review Comment:
@cmccabe There is a test that's meant to catch this exception, but it was
buggy:
https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala#L137
What's the expected behavior now and should the code or test be changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
