mjsax commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1399777340
##########
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##########
@@ -1584,7 +1646,43 @@ public <V> void shouldHandleKeyQuery(
);
final V result1 = queryResult.getResult();
- final Integer integer = valueExtactor.apply(result1);
+ final Integer integer = (Integer) result1;
+ assertThat(integer, is(expectedValue));
+ assertThat(queryResult.getExecutionInfo(), is(empty()));
+ assertThat(queryResult.getPosition(), is(POSITION_0));
+ }
+
+ public <V> void shouldHandleTimestampedKeyQuery(
+ final Integer key,
+ final Integer expectedValue) {
Review Comment:
We should compare both (what happens automatically if you compare
`ValueAndTimestamp` type). Thus, you need to set the right timestamp on
expected `ValueAndTimestamp`.
The ts comes from the data, and is set in `before()` to `WINDOW_START +
Duration.ofMinutes(2).toMillis() * i` when input data is written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
