Lucent-Wong commented on code in PR #14666: URL: https://github.com/apache/kafka/pull/14666#discussion_r1400935789
########## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala: ########## @@ -3782,6 +3784,33 @@ class GroupCoordinatorTest { assertTrue(groupCoordinator.tryCompleteHeartbeat(group, leaderMemberId, false, () => true)) } + @Test + def testUpdateStaticMemberButStoreGroupFailed(): Unit = { + val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId, followerInstanceId, DefaultSessionTimeout, DefaultRebalanceTimeout, "oldClientId", "oldClientHost") + val oldGroup = getGroup(groupId) + val oldMemberId = oldGroup.currentStaticMemberId(followerInstanceId) + val oldMember = oldGroup.get(oldMemberId.get) + val oldClientId = oldMember.clientId + val oldClientHost = oldMember.clientHost + + val joinGroupResult = staticJoinGroupWithPersistence(groupId, JoinGroupRequest.UNKNOWN_MEMBER_ID, + followerInstanceId, protocolType, protocolSuperset, clockAdvance = 1, appendRecordError = Errors.MESSAGE_TOO_LARGE) + + checkJoinGroupResult(joinGroupResult, + Errors.UNKNOWN_SERVER_ERROR, + rebalanceResult.generation, + Set.empty, + Stable, + Some(protocolType)) + + val newGroup = getGroup(groupId) Review Comment: OK, let change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org