rreddy-22 commented on code in PR #14481:
URL: https://github.com/apache/kafka/pull/14481#discussion_r1400998694
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##########
@@ -96,7 +96,7 @@ public GroupAssignment assign(
private boolean allSubscriptionsEqual(Map<String, AssignmentMemberSpec>
members) {
Set<Uuid> firstSubscriptionSet = new
HashSet<>(members.values().iterator().next().subscribedTopicIds());
for (AssignmentMemberSpec memberSpec : members.values()) {
- if
(!firstSubscriptionSet.containsAll(memberSpec.subscribedTopicIds())) {
+ if (!firstSubscriptionSet.equals(new
HashSet<>(memberSpec.subscribedTopicIds()))) {
Review Comment:
yes cause the old way means every element in memberSpec.subscribedTopicIds()
must be in firstSubscriptionSet, but firstSubscriptionSet can have additional
elements that are not in memberSpec.subscribedTopicIds(). We need a strict
equality check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
