vamossagar12 commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1824302840
Thanks @ableegoldman , that makes sense. Well I have another question again due to me not being upto date with the latest developments in streams. I have this test in `StreamThreadTest` namely `shouldPauseNonEmptyPartitionsWhenTotalBufferSizeExceedsMaxBufferSize` and which are failing for the case when `processingThreadsEnabled` is set to true. I have another test which is failing but the 2 seem related. The reason for the failure is [this](https://github.com/apache/kafka/pull/13283/files#diff-e75351ae918dc9830b36a2c407203bfc4212ef78a658f053a2905e312ed47edfR3519-R3524), basically we are expecting `paused()` and `resume()` to be invoked. I think when we don't have processingThreadEnabled, the buffer size is reduced after `pollPhase` but this PR was pre-processingThreadEnabled so, I didn't have the checks. Now the question is, does it make sense to have this buffer based checks for the latter case? Because, IIUC, when `processingThreadEnabled` is true, the processing is being done on separate threads and not on this stream thread. When we don't have separate processing threads, it makes sense to track the memory usage on the StreamThread and pause/resume (which is what the original JIRA was about). Is my understanding correct? I can work around the test cases if it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
