Re: [PR] MINOR: Query before creating the internal remote log metadata topic [kafka]

[via GitHub]

kamalcph commented on code in PR #14755:
URL: https://github.com/apache/kafka/pull/14755#discussion_r1404579784


##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##########
@@ -66,6 +69,28 @@ public TopicBasedRemoteLogMetadataManager topicBasedRlmm() {
         return remoteLogMetadataManagerHarness.remoteLogMetadataManager();
     }
 
+    @Test
+    public void testInternalTopicExists() {
+        Properties adminConfig = 
remoteLogMetadataManagerHarness.adminClientConfig();
+        ListenerName listenerName = 
remoteLogMetadataManagerHarness.listenerName();
+        try (Admin admin = 
remoteLogMetadataManagerHarness.createAdminClient(listenerName, adminConfig)) {
+            String topic = 
topicBasedRlmm().config().remoteLogMetadataTopicName();
+            boolean doesTopicExist = topicBasedRlmm().doesTopicExist(admin, 
topic);
+            Assertions.assertTrue(doesTopicExist);

Review Comment:
   Opened #14840 to fix this test. Ran the test locally repeatedly (100) to 
ensure that it does not fail this time:
   
   <img width="885" alt="Screenshot 2023-11-24 at 11 50 47 PM" 
src="https://github.com/apache/kafka/assets/11411249/3912af3d-269f-4a34-966f-4a9096b49f30";>
   
   PTAL



##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##########
@@ -66,6 +69,28 @@ public TopicBasedRemoteLogMetadataManager topicBasedRlmm() {
         return remoteLogMetadataManagerHarness.remoteLogMetadataManager();
     }
 
+    @Test
+    public void testInternalTopicExists() {
+        Properties adminConfig = 
remoteLogMetadataManagerHarness.adminClientConfig();
+        ListenerName listenerName = 
remoteLogMetadataManagerHarness.listenerName();
+        try (Admin admin = 
remoteLogMetadataManagerHarness.createAdminClient(listenerName, adminConfig)) {
+            String topic = 
topicBasedRlmm().config().remoteLogMetadataTopicName();
+            boolean doesTopicExist = topicBasedRlmm().doesTopicExist(admin, 
topic);
+            Assertions.assertTrue(doesTopicExist);

Review Comment:
   Opened #14840 to fix this test. Ran the test locally repeatedly (100) to 
ensure that it does not fail this time:
   
   <img width="885" alt="Screenshot 2023-11-24 at 11 50 47 PM" 
src="https://github.com/apache/kafka/assets/11411249/3912af3d-269f-4a34-966f-4a9096b49f30";>
   
   PTAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org