kamalcph commented on code in PR #14649:
URL: https://github.com/apache/kafka/pull/14649#discussion_r1404591766


##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1754,6 +1754,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
         leaderEpochCache.foreach(_.clearAndFlush())
         producerStateManager.truncateFullyAndStartAt(newOffset)
         logStartOffset = logStartOffsetOpt.getOrElse(newOffset)
+        _localLogStartOffset = newOffset

Review Comment:
   @nikramakrishnan 
   
   Can we reuse the same approach?
   
   ```
   if (remoteLogEnabled()) _localLogStartOffset = newOffset
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to