vamossagar12 commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1405738152
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java:
##########
@@ -691,6 +735,91 @@ public void testDeleteMember() {
assertEquals(expectedAssignment, result.targetAssignment());
}
+ @Test
+ public void testStaticMemberReplace() {
+ TargetAssignmentBuilderTestContext context = new
TargetAssignmentBuilderTestContext(
+ "my-group",
+ 20
+ );
+
+ Uuid fooTopicId = context.addTopicMetadata("foo", 6,
Collections.emptyMap());
+ Uuid barTopicId = context.addTopicMetadata("bar", 6,
Collections.emptyMap());
+
+ context.addGroupMember("member-1", "member-1", Arrays.asList("foo",
"bar", "zar"), mkAssignment(
+ mkTopicAssignment(fooTopicId, 1, 2),
+ mkTopicAssignment(barTopicId, 1, 2)
+ ));
+
+ context.addGroupMember("member-2", "member-2", Arrays.asList("foo",
"bar", "zar"), mkAssignment(
+ mkTopicAssignment(fooTopicId, 3, 4),
+ mkTopicAssignment(barTopicId, 3, 4)
+ ));
+
+ context.addGroupMember("member-3", "member-3", Arrays.asList("foo",
"bar", "zar"), mkAssignment(
+ mkTopicAssignment(fooTopicId, 5, 6),
+ mkTopicAssignment(barTopicId, 5, 6)
+ ));
+
+ context.updateMemberSubscription("member-1", Arrays.asList("foo",
"bar", "zar"), Optional.of("member-1"), Optional.empty());
+ context.updateMemberSubscription("member-2", Arrays.asList("foo",
"bar", "zar"), Optional.of("member-2"), Optional.empty());
+ context.updateMemberSubscription("member-3", Arrays.asList("foo",
"bar", "zar"), Optional.of("member-3"), Optional.empty());
Review Comment:
I see. Thanks for the explanation, I hadn't understood the usage of these
methods correctly. I have removed these unwanted calls to
`updateMemberSubscription`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
