philipnee opened a new pull request, #14842:
URL: https://github.com/apache/kafka/pull/14842

   A few bugs was created from the previous issues. These are:
   1. During testing or some edge cases, the coordinator request manager might 
hold on to an inflight request forever. Therefore, when invoking 
coordinatorRequestManager.poll(), nothing would return.  Here we explicitly 
create a FindCoordinatorRequest regardless of the current request state because 
we want to actively search for a coordinator
   2. ensureCoordinatorReady() might be stuck in an infinite loop forever if 
the client fail to do so.  Even the consumer would be able to shutdown 
eventually, this is undesirable.
   3. The current asyncConsumerTest mixes background/network thread shutdown 
with the consumer shutdown.  As the goal of the module is unit testing, we 
should try to test the shutdown procedure separately.  Therefore, this PR adds 
a Mockito.doAnswer call to the applicationEventHandler.close().  Tests that are 
testing shutdown are calling shutdown() explicitly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to