mumrah commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1407976249
########## clients/src/main/java/org/apache/kafka/common/requests/DescribeTopicPartitionsResponse.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.common.requests; + +import org.apache.kafka.common.message.DescribeTopicPartitionsResponseData; +import org.apache.kafka.common.message.DescribeTopicPartitionsResponseData.DescribeTopicPartitionsResponseTopic; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +public class DescribeTopicPartitionsResponse extends AbstractResponse { + private final DescribeTopicPartitionsResponseData data; + + public DescribeTopicPartitionsResponse(DescribeTopicPartitionsResponseData data) { + super(ApiKeys.DESCRIBE_TOPIC_PARTITIONS); + this.data = data; + } + + @Override + public DescribeTopicPartitionsResponseData data() { + return data; + } + + @Override + public int throttleTimeMs() { + return data.throttleTimeMs(); + } + + @Override + public void maybeSetThrottleTimeMs(int throttleTimeMs) { + data.setThrottleTimeMs(throttleTimeMs); + } + + @Override + public boolean shouldClientThrottle(short version) { + return true; + } + + @Override + public Map<Errors, Integer> errorCounts() { + Map<Errors, Integer> errorCounts = new HashMap<>(); + data.topics().forEach(topicResponse -> { + topicResponse.partitions().forEach(p -> updateErrorCounts(errorCounts, Errors.forCode(p.errorCode()))); + updateErrorCounts(errorCounts, Errors.forCode(topicResponse.errorCode())); + }); + return errorCounts; + } + + public static DescribeTopicPartitionsResponse prepareResponse(int throttleTimeMs, Review Comment: nit: can you reformat this as: ``` prepareResponse( int throttleTimeMs, ... ) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
