cmccabe commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408398127
##########
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##########
@@ -377,7 +386,7 @@ public ApiMessageAndVersion toRecord(Uuid topicId, int
partitionId, ImageWriterO
record.setDirectories(Uuid.toList(directories));
} else {
for (Uuid directory : directories) {
- if (!DirectoryId.UNASSIGNED.equals(directory)) {
+ if (!DirectoryId.UNASSIGNED.equals(directory) &&
!DirectoryId.MIGRATING.equals(directory)) {
Review Comment:
`UNASSIGNED` doesn't exist in the pre-JBOD world, so losing it is a loss of
metadata. Even if that metadata is worthless. So I think we should just be
special-casing `MIGRATING` and nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
