cadonna commented on PR #14842: URL: https://github.com/apache/kafka/pull/14842#issuecomment-1831462346
I totally agree on not using spies. That is my opinion and also the Mockito documentation says to be really careful with spies and to just use them if absolutely needed. Spies are mostly used to test legacy code and they should not be used for new code. We should definitely not wrap the code to test into spies. In my current PR, a unit test was not working because of this wrapping. I started to improve the test code in a separate PR, but the PRs for the deadline have higher priority. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
