dajac commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1409230711
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##########
@@ -458,9 +458,9 @@ private CoordinatorContext(
private void updateLastWrittenOffset(
long offset
) {
- if (offset <= lastWrittenOffset) {
+ if (offset < lastWrittenOffset) {
Review Comment:
Hum... I am not sure about this because the offset should always increase.
This is an important invariant of the system and by relaxing this we could
potentially violate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
