apoorvmittal10 commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1409714105
##########
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##########
@@ -550,6 +576,41 @@ public void close() {
}
}
+ @Override
+ public void initiateClose(long timeoutMs) {
+ log.debug("initiate close for client telemetry, check if terminal
push required. Timeout {} ms.", timeoutMs);
+
+ lock.writeLock().lock();
+ try {
+ // If we never fetched a subscription, we can't really push
anything.
+ if (lastRequestMs == 0) {
+ log.info("Telemetry subscription not loaded, not
attempting terminating push");
Review Comment:
Missed it, my bad, earlier kept everything at INFO for local testing. Moved
to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
