mjsax commented on code in PR #14864: URL: https://github.com/apache/kafka/pull/14864#discussion_r1409030872
########## streams/src/main/java/org/apache/kafka/streams/ClientInstanceIds.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams; + +import org.apache.kafka.common.Uuid; + +import java.util.Map; + +/** + * Encapsulates the {@code client instance id} used for metrics collection by + * producers, consumers, and the admin client used by Kafka Streams. + */ +public interface ClientInstanceIds { Review Comment: I updated the KIP and changed this from `class` to `interface`. ########## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ########## @@ -1791,6 +1794,56 @@ protected int processStreamThread(final Consumer<StreamThread> consumer) { return copy.size(); } + /** + * Returns the internal clients' assigned {@code client instance ids}. + * + * @return the internal clients' assigned instance ids used for metrics collection. + * + * @throws IllegalStateException If {@code KafkaStreams} is not running. Review Comment: I updated the KIP and change this to `IllegalStateException` (it does not make sense to throw an sub-class of `InvalidStateStoreException` and other methods on `KafkaStreams` also use `IllegalStateException`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
