cadonna commented on code in PR #14872:
URL: https://github.com/apache/kafka/pull/14872#discussion_r1410551672
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -752,6 +757,70 @@ public void testSubscriptionOnEmptyTopic() {
assertThrows(IllegalArgumentException.class, () ->
consumer.subscribe(singletonList(emptyTopic)));
}
+ @Test
+ public void testGroupIdIsNull() {
+ final Properties props = requiredConsumerProperties();
+ props.put(ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG, 10000);
+ props.put(THROW_ON_FETCH_STABLE_OFFSET_UNSUPPORTED, true);
+ final ConsumerConfig config = new ConsumerConfig(props);
+
+ try (AsyncKafkaConsumer<String, String> consumer =
+ new AsyncKafkaConsumer<>(config, new StringDeserializer(),
new StringDeserializer())) {
+
assertFalse(config.unused().contains(ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG));
+
assertFalse(config.unused().contains(THROW_ON_FETCH_STABLE_OFFSET_UNSUPPORTED));
+ } catch (final Exception exception) {
+ throw new AssertionFailedError("The following exception was not
expected:", exception);
+ }
+ }
+
+ @Test
+ public void testGroupIdIsNotNullAndValid() {
+ final Properties props = requiredConsumerProperties();
+ props.put(ConsumerConfig.GROUP_ID_CONFIG, "consumerGroupA");
+ props.put(ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG, 10000);
+ props.put(THROW_ON_FETCH_STABLE_OFFSET_UNSUPPORTED, true);
+ final ConsumerConfig config = new ConsumerConfig(props);
+
+ try (AsyncKafkaConsumer<String, String> consumer =
+ new AsyncKafkaConsumer<>(config, new StringDeserializer(),
new StringDeserializer())) {
+
assertTrue(config.unused().contains(ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG));
+
assertTrue(config.unused().contains(THROW_ON_FETCH_STABLE_OFFSET_UNSUPPORTED));
+ } catch (final Exception exception) {
+ throw new AssertionFailedError("The following exception was not
expected:", exception);
+ }
+ }
+
+ @Test
+ public void testGroupIdEmpty() {
+ testGroupId("");
+ }
+
+ @Test
+ public void testGroupIdOnlyWhitespaces() {
+ testGroupId(" ");
+ }
+
+ private void testGroupId(final String groupId) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
