cmccabe commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1411470125
##########
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##########
@@ -95,7 +96,10 @@ public void close() throws InterruptedException {
}
public void onAssignment(TopicIdPartition topicPartition, Uuid dirId) {
Review Comment:
Do we need two constructors for this? Seems like someone could just pass a
callback that doesn't do anything, if they don't want any.
Also, I don't see a null check later for `assignmentEvent.callback` ... so
is null even allowed here?
##########
server/src/main/java/org/apache/kafka/server/AssignmentsManager.java:
##########
@@ -391,4 +402,4 @@ static AssignReplicasToDirsRequestData buildRequestData(int
brokerId, long broke
.setBrokerEpoch(brokerEpoch)
.setDirectories(new ArrayList<>(directoryMap.values()));
}
-}
+}
Review Comment:
don't need this change
##########
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##########
@@ -248,4 +248,4 @@ void testRequeuesFailedAssignmentPropagations() throws
InterruptedException {
}}
), captor.getAllValues().get(4).build().data());
}
-}
+}
Review Comment:
don't need this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
