ashwinpankaj commented on code in PR #14893: URL: https://github.com/apache/kafka/pull/14893#discussion_r1411813212
########## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ########## @@ -770,6 +771,9 @@ public void testSyncTopicConfigs() throws InterruptedException { Map<ConfigResource, Collection<AlterConfigOp>> configOps = Collections.singletonMap(configResource, ops); // alter configs on target cluster backup.kafka().incrementalAlterConfigs(configOps); + // wait until the configs are changed + waitForConfigValueChange(backup, backupTopic, "delete.retention.ms", "2000"); + waitForConfigValueChange(backup, backupTopic, "retention.bytes", "2000"); Review Comment: thanks looking into this @atu-sharm ! I wonder if a wait for `retention.bytes` to be equal to 2000 will always succeed. waitForCondition has a default poll interval of 100 ms. If the value is set to 2000 and then changed to 1000 by MirrorMaker within the time the thread sleeps (100ms) , we may miss the value change and timeout. Can't we just wait on the futures returned by incrementalAlterConfigs ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org