[
https://issues.apache.org/jira/browse/KAFKA-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518357#comment-16518357
]
Konstantine Karantasis commented on KAFKA-6914:
-----------------------------------------------
I'm in favor of the change. All I can say is that we were a bit conservative at
the start and stayed on the safe side until we see how things would play out
with class loading isolation overall. That's why the parent was pinned to the
system classloader. Also I remember that by switching the plugin's classloader
to the thread context one's I was hoping that OSGi like frameworks could still
work (similar to a change Kafka had done in {{ConfigDef}} previously).
I'll issue a PR
> Kafka Connect - Plugins class should have a constructor that can take in
> parent ClassLoader
> -------------------------------------------------------------------------------------------
>
> Key: KAFKA-6914
> URL: https://issues.apache.org/jira/browse/KAFKA-6914
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Reporter: Sriram KS
> Priority: Minor
>
> Currently Plugins class has a single constructor that takes in map of props.
> Please make Plugin class to have a constructor that takes in a classLoader as
> well and use it to set DelegationClassLoader's parent classLoader.
> Reason:
> This will be useful if i am already having a managed class Loader environment
> like a Spring boot app which resolves my class dependencies using my
> maven/gradle dependency management.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
