nicktelford commented on PR #14852: URL: https://github.com/apache/kafka/pull/14852#issuecomment-1836136670
@cadonna > Do we have unit tests in place that test all this logic? We don't have any tests dedicated to this, but `RocksDBStoreTest` and `RocksDBTimestampedStoreTest` implicitly test both the case that we only have the default CF, and the case that we have an extra CF (for the timestamped values). These tests fail spectacularly when any of this logic has a bug in it. Also, most of the integration tests break pretty badly when any of this is wrong. Are there any additional tests you'd like me to add? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
