lianetm commented on code in PR #14878:
URL: https://github.com/apache/kafka/pull/14878#discussion_r1412491852
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -783,6 +774,7 @@ void markReconciliationCompleted() {
* </ol>
*/
private void resolveMetadataForUnresolvedAssignment() {
+ assignmentReadyToReconcile.clear();
Review Comment:
This call here could make us loose assignments in some cases I expect (we
can have assignments ready to reconcile that are not being reconciled yet, and
then get more as a result of a metadata update. All need to be kept in the
buffer). Assignments ready to reconcile are discovered from 2 places (when we
get a HB response, but also when we get Metadata updates), and kept in the
buffer if there is a previous reconciliation going on.
Could you point me to the integration test that you mentioned brought this
situation up? I'll take a look to better understand what could be missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
