cmccabe commented on code in PR #14899:
URL: https://github.com/apache/kafka/pull/14899#discussion_r1412672706
##########
shell/src/main/java/org/apache/kafka/shell/MetadataShell.java:
##########
@@ -81,6 +85,21 @@ public MetadataShell build() {
}
}
+ static FileLock takeFileLock(File directory) {
+ FileLock fileLock = new FileLock(new File(directory, ".lock"));
Review Comment:
Yeah, that might make sense for this use-case. Since we also want to be able
to look at snapshots that aren't inside log dirs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
