aliehsaeedii commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1837630278
@hanyuzheng7 Thanks for the KIP and implementation. Maybe align the variable names with what you introduced in the KIP (or the other way around)? `newTimeFrom/To` -> `timeFrom/To` `timeFrom/To` -> `oldTimeFrom/To` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org