soarez commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1414647339


##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -166,6 +166,19 @@ class BrokerLifecycleManager(
    */
   private var registered = false
 
+  /**
+   * True if a request has been sent and a response or timeout has not yet 
been processed.

Review Comment:
   It applies to both Heartbeat and Registration requests which are the only 
requests this manager sends.
   
   I think we're also fixing a bug were a second registration request could 
have been scheduled after a call to `propagateDirectoryFailure` and before the 
registration response is received.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to