lihaosky commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1414713123
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java:
##########
@@ -394,6 +394,106 @@ public void testDeterministic() {
}
}
+ @Test
+ public void testMaxFlowOnlySourceAndSink() {
+ final Graph<Integer> graph1 = new Graph<>();
Review Comment:
`graph` was used in setup
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/BalanceSubtopologyGraphConstructor.java:
##########
@@ -88,55 +93,20 @@ public Graph<Integer> constructTaskGraph(
}
}
- // TODO: validate tasks in tasksForTopicGroup and taskIdList
- final SortedMap<Subtopology, Set<TaskId>> sortedTasksForTopicGroup =
new TreeMap<>(tasksForTopicGroup);
Review Comment:
It's put in `validateTasks`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
