mdedetrich commented on code in PR #12728:
URL: https://github.com/apache/kafka/pull/12728#discussion_r1416535578
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##########
@@ -887,19 +783,14 @@ public void testPutConnectorConfig() throws Exception {
assertEquals("bar", capturedConfig.getValue().get("foo"));
herder.connectorConfig(CONNECTOR_NAME, connectorConfigCb);
Review Comment:
Fixed and committed.
> It'd probably be better to do away with mocked callbacks and switch to
using a `FutureCallback` that we invoke `get` on (like we do with many other
tests), but it's up to you if you'd like to implement that or not.
I think its better to solve this as another PR/issue. This PR has already
been ongoing for long enough and this just appears to be a nice improvement for
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
